Commit 24b5e1b5 authored by Rieks Joosten's avatar Rieks Joosten

Created issues for the review points

parent a9340227
# https://gitlab.grnet.gr/essif-lab/framework/-/blob/master/docs/introduction.md
The list under eSSIF-Lab Framework repository contains two items, it
should also contain an item for "SSI Standards".
Also, eSSIF-Lab Framework repository => eSSIF-Lab Framework Repository
# https://gitlab.grnet.gr/essif-lab/framework/-/blob/master/docs/essif-lab-vision-and-purpose.md
a secure communications channel (e.g. SSL, DIDComm) => Give reference
to DIDComm.
# https://gitlab.grnet.gr/essif-lab/framework/-/blob/master/docs/essif-lab-functional-architecture.md
Note that in the document, the various terms are not always
capitalized; for example we may see "owner" or "Owner". For
consistency and ease of understanding, all such terms should be
capitalized.
Figure 1 shows the initial functional eSSIF-Lab architecture, and its
scope, context and (functional) components each of which is an agent
for the same party (meaning that they are all part of the same
organization as defined above, and they are all (digital) ‘colleagues’
of one another). => What exactly are the functional components each
one of which is an agent of the same party? In exactly the following
paragraph the point is made that a transaction is executed with agents
of different parties. So, where in the figures are the agents of the
same party (organization)?
In section 2.4, we have Transaction (Validation) Engine and
Transaction Result Dispatcher spelled out in full, while previously
their acronyms were used. Better to be consistent and use acronyms.
The specification of these API’s can be found in [reference needed].
=> reference is missing.
The specification of such requests is given in [reference needed]. =>
Missing reference.
Concerning section 4, Initial SSI-Agent Network Architecture, I did
not really understand it or its purpose.
The figure in 5.1 runs against the text.
Section 6 seems to be still work in progress? It states that "this
section is being constructed now (it is only for the very curious to
read...)"
In 6.2 there remains a "[text still needs to be written]"
# https://gitlab.grnet.gr/essif-lab/framework/-/blob/master/docs/ssi-standards.md
transmitting and storing verifiable digital credentials VCs => spell
out VCs.
DIF has recently begun work on defining the specs => the DIF has
recently begun work on defining the specs
General Comment:
Apart from the SSI Standards text
(https://gitlab.grnet.gr/essif-lab/framework/-/blob/master/docs/ssi-standards.md),
the other parts do not use dashes correctly; they only use hyphens
instead of em dashes.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment