Review comments of Panos regarding `essif-lab-functional-architecture.md`
-
(1) Note that in the document, the various terms are not always capitalized; for example we may see "owner" or "Owner". For consistency and ease of understanding, all such terms should be capitalized.
-
(2) Figure 1 shows the initial functional eSSIF-Lab architecture, and its scope, context and (functional) components each of which is an agent for the same party (meaning that they are all part of the same organization as defined above, and they are all (digital) ‘colleagues’ of one another). => What exactly are the functional components each one of which is an agent of the same party? In exactly the following paragraph the point is made that a transaction is executed with agents of different parties. So, where in the figures are the agents of the same party (organization)?
-
(3) In section 2.4, we have Transaction (Validation) Engine and Transaction Result Dispatcher spelled out in full, while previously their acronyms were used. Better to be consistent and use acronyms.
-
(4) The specification of these API’s can be found in [reference needed]. => reference is missing.
-
(5) The specification of such requests is given in [reference needed]. => Missing reference.
-
(6) Concerning section 4, Initial SSI-Agent Network Architecture, I did not really understand it or its purpose.
-
(7) The figure in 5.1 runs against the text.
-
(8) Section 6 seems to be still work in progress? It states that "this section is being constructed now (it is only for the very curious to read...)"
-
(9) In 6.2 there remains a "[text still needs to be written]"